[konsole] [Bug 401898] Closing a tab is slow with something written on the prompt

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=401898

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
                   |ities/konsole/commit/3d967a |ities/konsole/commit/18dc0f
                   |597472a75b2afbd75afb20d7f44 |de2b47b70ac65e4a0400ed0b79c
                   |a3881f2                     |12b1196

--- Comment #18 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 18dc0fde2b47b70ac65e4a0400ed0b79c12b1196 by Kurt Hindenburg, on
behalf of Christoph Cullmann.
Committed on 06/09/2021 at 16:35.
Pushed by hindenburg into branch 'release/21.08'.

improve session closing behavior

the new session close behavior is again the old

- first send SIGHUP and wait one second if that works
- then hard kill

before we tried to send an EOF character
this needed workaround to not kill "non shell" programs
unexpected and doesn't work e.g. if

- you have some not finished command input in your shell
- on e.g. FreeBSD in general

When closing the session with some background process still running:
- using Ctrl+D (which sends EOF) will leave that background process running
  (which is the expected behaviour with e.g. BASH:
  https://lists.gnu.org/archive/html/bug-bash/2009-03/msg00091.html)
- using e.g. the close button on the titlebar will close the session and kill
any background processes

You can also use 'somecommand & disown', if you want to ensure background
processes
aren't killed when you close a konsole window.
Related: bug 185140
(cherry picked from commit 3d967a597472a75b2afbd75afb20d7f44a3881f2)

M  +0    -16   src/Pty.cpp
M  +0    -5    src/Pty.h
M  +7    -18   src/session/Session.cpp

https://invent.kde.org/utilities/konsole/commit/18dc0fde2b47b70ac65e4a0400ed0b79c12b1196

-- 
You are receiving this mail because:
You are the assignee for the bug.