[konsole] [Bug 436916] Konsole Crashes When Zooming in Amp Editor

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=436916

tcanabrava at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/2a78bb
                   |                            |6ef3b81d1b381c0f48d4141597a
                   |                            |4c953fa
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from tcanabrava at kde.org ---
Git commit 2a78bb6ef3b81d1b381c0f48d4141597a4c953fa by Tomaz  Canabrava, on
behalf of Luis Javier Merino Morán.
Committed on 24/06/2021 at 08:32.
Pushed by tcanabrava into branch 'master'.

Fix crash/warn on history reflow

When the last line in history was marked as wrapped, the history reflow
algorithm could try to make an out-of-bound access.

These were found via repeteadly zooming-in and out in the amp.rs editor
(available through Rust's cargo tool).  amp.rs writes in the normal
buffer (not in the alternate buffer).

While at it, add a Q_ASSERT in HistoryScrollFile::startOfLine() to
ensure parameters are in range.  Note that after an addCells()/addLine()
pair, HistoryScrollFile::startOfLine(getLines) always has the same value
as _cells.len().

M  +5    -3    src/history/HistoryScrollFile.cpp
M  +1    -1    src/history/compact/CompactHistoryScroll.cpp

https://invent.kde.org/utilities/konsole/commit/2a78bb6ef3b81d1b381c0f48d4141597a4c953fa

-- 
You are receiving this mail because:
You are the assignee for the bug.