[konsole] [Bug 433160] New: Confusing implementation of profiles - temporary changes, saving etc

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=433160

            Bug ID: 433160
           Summary: Confusing implementation of profiles - temporary
                    changes, saving etc
           Product: konsole
           Version: master
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: konsole-devel at kde.org
          Reporter: jjm at keelhaul.me.uk
  Target Milestone: ---

SUMMARY

Konsole's profile system works as intended for permanent profiles saved. 
However, some confusion arises when temporary changes cause a new profile to be
generated, which happens without any indication to the user and changes the way
that editing the profile works.

For example, start Konsole with the default settings, then "Edit Current
Profile".  Any changes can be made, and then "OK" or "Apply" applies the
settings and updates the saved profile permanently.  So far so good.

Then start Konsole again with a seemingly innocuous change, e.g. with
"--workdir /tmp".  Then do "Edit Current Profile" again and try to change the
appearance (without noticing that the profile name on the "General" page is now
blank).  Either "OK" or "Apply" gives the message "Each profile must have a
name before it can be saved into disk" (which is badly worded, and also shows
in two message boxes in succession) and nothing happens.

Even if nothing is changed on the command line, executing an escape sequence
which changes a profile property (e.g. as described in bug 323227) will do the
same.

The effect of this is that the user cannot change anything, even if they only
want the change to be temporary for the current session, without having to
enter a name and saving the profile.  Even if they realise what is happening it
is not possible to simply enter the original name and overwrite the saved
profile, because it already exists and there is no option to overwrite it.


SUGGESTED SOLUTION

Retain the current "Edit Current Profile" action and dialogue, but separate its
eventual result into two distinct "change the current session" and "save the
profile permanently" actions.  This could be done by having a "Save" button in
addition to "OK" and "Apply".  There could also be, if the profile is a
temporary one (i.e. it has no name and is not saved), a message something like
"This is a temporary profile, please enter a name to save it".

Clicking "Save" will save the profile to disc, with an error message if it has
no name or an overwrite warning if the name already exists.  This should be the
default button if the profile is not temporary, and if the save is successful
should also have the effect of "OK".

Clicking "OK" or "Apply" will apply the profile to the current session, without
insisting that the profile has a name or saving it.  "OK" should be the default
button if the profile is temporary.

-- 
You are receiving this mail because:
You are the assignee for the bug.