[konsole] [Bug 447074] Split-view creates uneven views

[Alfonso Murolo]

https://bugs.kde.org/show_bug.cgi?id=447074

--- Comment #5 from Alfonso Murolo <almur.kde at gmail.com> ---
(In reply to tcanabrava from comment #4)
> Created attachment 144677 [details]
> attachment-4483-0.html
> 
> you are correct, there is a bug there, I have never realized it.
> Do you want to try to solve it? code *should* not be complex.
> if not, I can try later on.
> 
> 
> On Sun, Dec 19, 2021 at 10:39 AM Alfonso Murolo <bugzilla_noreply at kde.org>
> wrote:
> 
> > https://bugs.kde.org/show_bug.cgi?id=447074
> >
> > --- Comment #3 from Alfonso Murolo <almur.kde at gmail.com> ---
> > (In reply to tcanabrava from comment #2)
> > > Created attachment 144670 [details]
> > > attachment-25446-0.html
> > >
> > > Subsequent commands splits the *current* container in exactly half.
> > > I understand the request but I think it would be complex to implement
> > > considering that the old behavior you could do only vertical *or*
> > > horizontal splits, not combine them. (so it was easy to just reorganize
> > the
> > > screen dividing the width by the number of splits)
> > >
> > > Now we can combine splits, horizontal and vertical, so resizing all
> > panels
> > > is not so straightforward.
> > >
> > >
> > > Le dim. 19 déc. 2021 à 09:51, Alfonso Murolo <bugzilla_noreply at kde.org>
> > a
> > > écrit :
> > >
> > > > https://bugs.kde.org/show_bug.cgi?id=447074
> > > >
> > > > Alfonso Murolo <almur.kde at gmail.com> changed:
> > > >
> > > >            What    |Removed                     |Added
> > > >
> > > >
> > ----------------------------------------------------------------------------
> > > >                  CC|                            |almur.kde at gmail.com
> > > >
> > > > --- Comment #1 from Alfonso Murolo <almur.kde at gmail.com> ---
> > > > I can confirm this, I have tried it on my personal machine (Konsole
> > 21.12
> > > > on
> > > > Archlinux) and on Konsole master (22.03.70). I am looking into why this
> > > > happens. At a certain point I started thinking that maybe this could be
> > > > intended, but the fact that the first command spilits in exactly half,
> > and
> > > > subsequent commands don´t, is to me giving away that something is odd.
> > > >
> > > > --
> > > > You are receiving this mail because:
> > > > You are the assignee for the bug.
> >
> > As I am not very familiar with the code of the ViewSplitter, and I chose
> > this
> > issue as the first one ever to look at (:D), please take my words with a
> > grain
> > of salt: it seems from the behaviour however that the sizes of the current
> > container are incorrectly referenced to.
> >
> > This results in a failure:
> > 1. Split the views in half top/bottom. Views will be split correctly
> > 2. Kill the bottom view. Now only one view exists, exactly identical to the
> > first
> > 3. Split the view in half top/bottom again. Current container should,
> > intuitively, be exactly the same size of the original container, to be
> > split in
> > half. Observe the failure in splitting in half a second time.
> >
> > --
> > You are receiving this mail because:
> > You are the assignee for the bug.

I´d like to try to fix it. As it is my first issue, it will probably take me a
while to figure out how the entire splitter works, but hopefully it shouldn´t
be too hard :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.