[konsole] [Bug 441206] Dolphin crashes after closing it while terminal is open.

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=441206

Ahmad Samir <a.samirh78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |21.08.1
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/2684bc
                   |                            |7fa5ac0b740b3e8661c3a0ae013
                   |                            |6fde0a7
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Ahmad Samir <a.samirh78 at gmail.com> ---
Git commit 2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7 by Ahmad Samir.
Committed on 22/08/2021 at 18:10.
Pushed by tcanabrava into branch 'master'.

Only emit empty() in SessionFinished() when in TabbedNavigation mode

empty() is emitted so that MainWindow calls close() and we get rid of the
colours-flashing bug when closing the last session/tab in a window, see
commit bbec72250d080. However all that isn't relevant when we are in
konsole Part mode, where there are no tabs or MainWindows.

This fixes a crash in Dolphin when closing its window while the embedded
Konsole Part is open. The crash would happen as calling
ViewContainer::currentTabViewCount() would end up in the ViewSplitter code
path, which is no-op in Konsole Part.

To test:
- Open dolphin, make sure the terminal panel isn't open to begin with
- open the terminal panel
- close the dolphin window while the terminal panel is open
FIXED-IN: 21.08.1

M  +7    -5    src/ViewManager.cpp

https://invent.kde.org/utilities/konsole/commit/2684bc7fa5ac0b740b3e8661c3a0ae0136fde0a7

-- 
You are receiving this mail because:
You are the assignee for the bug.