[konsole] [Bug 373440] konsole --new-tab opens window instead

[Tomaz Canabrava]

I think that the easiest thing there is to specify a pid for the tab.

--new-tab --parent-pid=

because, for multiple processes, it's impossible to know in *what* process
we want a new tab.

I have an old patch that fixes that, but breaks the multiple instance,
that's the reason martin added the DONT TOUCH part of the code.


On Thu, Jul 29, 2021 at 3:21 PM Igor Grkavac <bugzilla_noreply at kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=373440
>
> --- Comment #46 from Igor Grkavac <grkavac.igor at gmail.com> ---
> Hello,
>
> After pulling the latest commits on master, I can confirm that removing
>
> Konsole::KonsoleSettings::useSingleInstance()
>
> that I mentioned in my previous comment, I can get a new tab inside the
> same
> window on the first start.
>
> Can anyone from the commiters on the "DON'T TOUCH" part of the code:
>
>
> https://invent.kde.org/utilities/konsole/-/blob/fb69c183c672dff1d8e5e95d187622980255827c/src/main.cpp#L146
>
> confirm the usage as I am not familiar with why is that checked along with
> the
> problematic options that enforce to create a new process?
>
> If the useSingleInstance cannot be deleted, then it would need an
> additional
> flag just for the "--new-tab" option that will force a single process, not
> checking if useSingleInstance is enabled or not.
>
> Hope someone can help with this.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20210801/37498ebc/attachment-0001.htm>