[konsole] [Bug 412596] ViewSplitter is not destroyed

[Nikolay Zlatev]

https://bugs.kde.org/show_bug.cgi?id=412596

--- Comment #13 from Nikolay Zlatev <nik at astrapaging.com> ---
(In reply to Kurt Hindenburg from comment #12)
> Git commit c33eba8c60b99d00cd73c400d23b6f338ef32a85 by Kurt Hindenburg, on
> behalf of Carlos Alves.
> Committed on 02/11/2020 at 18:14.
> Pushed by hindenburg into branch 'master'.
> 
> Fix konsole crashes when rearranging split views
> 
> I'll try to explain here what I saw in this bug.
> Following the BUG instructions, drag the terminal[2] and drop
> (here the "drop event" starts)
> -> the dragged terminal "ViewSplitter" become scheduled for deletion,
> but it will only happens when it is in event loop.
> -> And of course it is not in event loop yet, it is still the
> "drop event" and it call the "addTerminalDisplay" to add the dragged
>  terminal to a "ViewSplitter".
> -> This makes count() counts this scheduled for deletion "ViewSplitter"
>  and goes to the wrong "if".
> -> It adds the "ViewSplitter" with the terminals into a
> "marked for deletion" one, finishes the "drop event" and enters
> event loop (a crash without a memleak! everything in the tab
>  is properly deleted).
> Related: bug 411741
> FIXED-IN: 20.12
> 
> M  +4    -0    src/widgets/ViewSplitter.cpp
> 
> https://invent.kde.org/utilities/konsole/commit/
> c33eba8c60b99d00cd73c400d23b6f338ef32a85


This commit doesn't fix the issue described here

Parent tree
Breeze::WidgetExplorer::eventFilter widget: 0x557e59a12c10
(Konsole::TerminalDisplay)
    parent: 0x557e59d8db80 (Konsole::ViewSplitter)
    parent: 0x557e59cc6800 (Konsole::ViewSplitter)
    parent: 0x557e599aeb10 (Konsole::ViewSplitter)
    parent: 0x557e59925c90 (Konsole::ViewSplitter)
    parent: 0x557e59926070 (Konsole::ViewSplitter)
    parent: 0x557e595eb2f0 (Konsole::ViewSplitter)
    parent: 0x557e59b450a0 (Konsole::ViewSplitter)
    parent: 0x557e59aa0c80 (Konsole::ViewSplitter)
    parent: 0x557e59a00230 (Konsole::ViewSplitter)
    parent: 0x557e5984ada0 (Konsole::ViewSplitter)
    parent: 0x557e59970f30 (Konsole::ViewSplitter)
    parent: 0x557e599c28c0 (Konsole::ViewSplitter)
    parent: 0x557e5962a530 (Konsole::ViewSplitter)
    parent: 0x557e5946ba10 (QStackedWidget)
    parent: 0x557e59424510 (Konsole::TabbedViewContainer)
    parent: 0x557e594143e0 (Konsole::MainWindow)

-- 
You are receiving this mail because:
You are the assignee for the bug.