[konsole] [Bug 416376] FileFilter only filters files in the current working directory, but not sub-directories

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=416376

Ahmad Samir <a.samirh78 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/kde/
                   |                            |konsole/commit/26f4a2218f52
                   |                            |f790d4de087216098619a753164
                   |                            |e
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ahmad Samir <a.samirh78 at gmail.com> ---
Git commit 26f4a2218f52f790d4de087216098619a753164e by Ahmad Samir.
Committed on 22/03/2020 at 18:05.
Pushed by hindenburg into branch 'master'.

[FileFilter] Create HotSpot's for files in child dirs too

When creating HotSpot's for local files, create them for files in the
current dir and for files in sub-directories too.

Re-format the code used to build the regex pattern for more readability
(easier for seeing what the regex pattern will look like, I hope).

Use a static QRegularExpression object, so as to only construct it once,
the pattern doesn't change and this should help with performance. Also
make createFileRegex() not static.

Don't convert QList<QString> to QSet<QString>, without actual benchmarking
it could be that QList is actually efficient here.

Use const where appropriate.

M  +47   -37   src/Filter.cpp
M  +1    -1    src/Filter.h

https://invent.kde.org/kde/konsole/commit/26f4a2218f52f790d4de087216098619a753164e

-- 
You are receiving this mail because:
You are the assignee for the bug.