[konsole] [Bug 421480] Pasting multiline text from Firefox results in double new lines between each text block

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=421480

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|20.08                       |20.04.3
      Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
                   |ities/konsole/commit/a10224 |ities/konsole/commit/6b6a1e
                   |42dc2f59321976fd3456ad97c61 |552492a25217cded1d83c25a652
                   |300d1f2                     |e5b249a

--- Comment #7 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 6b6a1e552492a25217cded1d83c25a652e5b249a by Kurt Hindenburg, on
behalf of Ahmad Samir.
Committed on 19/06/2020 at 14:49.
Pushed by hindenburg into branch 'release/20.04'.

Don't add extra newlines when pasting from GTK applications

Due to some internal handling in GTK itself, we end up with text copied
from Firefox where a newline is represented as CRLF (\r\n); since the
doPaste() method replaces each \n with \r, we ended up with \r\r, which
ultimately led to extra newlines in the pasted code. To fix the issue
simply detect the CRLF case and replace each \r\n with \r.

To test, copy some multiline text from Firefox, open vim in konsole and
paste, you end up with two newlines between each block of text. Compare the
results after applying this patch
FIXED-IN: 20.04.3
(cherry picked from commit a1022442dc2f59321976fd3456ad97c61300d1f2)

M  +4    -0    src/TerminalDisplay.cpp

https://invent.kde.org/utilities/konsole/commit/6b6a1e552492a25217cded1d83c25a652e5b249a

-- 
You are receiving this mail because:
You are the assignee for the bug.