D26764: Another revert to unbreak crash fix
Anthony Fieroni
noreply at phabricator.kde.org
Fri Jan 24 16:12:15 GMT 2020
anthonyfieroni added a comment.
In D26764#596862 <https://phabricator.kde.org/D26764#596862>, @kkharlamov wrote:
> Hi! Sorry, could you please elaborate why does it break the logic? Behavior of the code before and after the change should be the same because `unique_ptr` calls `delete app` upon going out of scope.
https://phabricator.kde.org/source/konsole/browse/master/src/main.cpp$172-175
KDBusService call exit then deleteQApplication is called qApp is https://phabricator.kde.org/source/konsole/browse/master/src/main.cpp$112 so it's deleted twice.
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D26764
To: sandsmark, #konsole, hindenburg, kkharlamov
Cc: anthonyfieroni, konsole-devel, hindenburg, #konsole, hiangel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200124/aa3419d3/attachment.html>
More information about the konsole-devel
mailing list