D26761: Unbreak opening in separate process and fix crashes

[Tomaz Canabrava]

tcanabrava added a comment.


  In D26761#596825 <https://phabricator.kde.org/D26761#596825>, @sandsmark wrote:
  
  > It works if not launched from another terminal I think, but Konsole explicitly launches a new instance in that case:
  >  F7892195: image.png <https://phabricator.kde.org/F7892195>
  >
  > But before that it checks if --new-tab is passed, and then forces re-using the existing, so I'm not sure why that doesn't work. But the correct thing to do is to fix that at least:
  >  F7892198: image.png <https://phabricator.kde.org/F7892198>
  >
  > Ideally we should pass along the environment to the existing konsole so it can set it in the new tab, but that involves reimplementing kdbusservice (like okular does), and is a bit less trivial.
  >
  > edit; I tested, and --new-tab works as expected with my revert.
  
  
  can you check if your konsole has the option "Run all konsole windows in a single process"?
  The problem that I had is that *if* this was not checked, --new-tab always created a new instance.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D26761

To: sandsmark, hindenburg, tcanabrava
Cc: cent, tcanabrava, hindenburg, konsole-devel, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200119/f5be85d4/attachment.html>