D26761: Unbreak opening in separate process and fix crashes

[Tomaz Canabrava]

Martin,

My patch fixed one bug (and probably created the others as you found out),
this patch reverts mine, but does —new-tab works if konsole is set to
multiple instances?

I don’t mind at all the revert of my commit, I just want something that
works correctly - I understand that mine doesn’t.

On Sun, 19 Jan 2020 at 11:11 Martin Tobias Holmedahl Sandsmark <
noreply at phabricator.kde.org> wrote:

> sandsmark created this revision.
> sandsmark added reviewers: hindenburg, tcanabrava.
> Herald added a project: Konsole.
> Herald edited subscribers, added: konsole-devel; removed: Konsole.
> sandsmark requested review of this revision. View Revision
> <https://phabricator.kde.org/D26761>
> *REVISION SUMMARY*
>
> 59ff5d37301adf4753b590f42787055e6695b614
> <https://phabricator.kde.org/R319:59ff5d37301adf4753b590f42787055e6695b614>
> completely ignored
> shouldUseNewProcess() which checks if we actually can re-use an existing
> process. This also broke --nofork, --separate etc.
>
> See the comments in shouldUseNewProcess() for why and when Konsole
> actually needs to use a new process.
>
> It also bypassed a crashfix because of the broken behavior of
> KDBusAddons because it didn't set the needToDeleteQApplication variable
> even though it forced reusing an existing an existing process.
>
> See https://bugs.kde.org/show_bug.cgi?id=355545
>
> *TEST PLAN*
>
> Konsole now reuses a process if possible and wanted by the user, otherwise
> forces a new process.
>
> *REPOSITORY*
> R319 Konsole
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D26761
>
> *AFFECTED FILES*
> src/main.cpp
>
> *To: *sandsmark, hindenburg, tcanabrava
> *Cc: *tcanabrava, hindenburg, konsole-devel, cent, EspadaV8,
> fbampaloukas, thsurrel, ngraham, maximilianocuria
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200119/7c45905f/attachment.html>