D26479: Fix warning on launch from QCommandLineParser

Wolfgang Bauer noreply at phabricator.kde.org
Wed Jan 8 08:16:00 GMT 2020


wbauer added a comment.


  In D26479#589636 <https://phabricator.kde.org/D26479#589636>, @hindenburg wrote:
  
  > I think this needs a Qt5 and KF5 check; there's no reason to remove in earlier versions.
  
  
  It would only need a KF5 check:
  #if KCOREADDONS_VERSION < QT_VERSION_CHECK(5,7,0)
  
  The Qt version doesn't matter, it's just that earlier versions don't print a runtime warning if an option is added twice.
  
  But, @lmontel already committed this change also to konsole an hour ago:
  https://cgit.kde.org/konsole.git/commit/?id=ac630f7fb15506ef4a49bab519361697c30ff273

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D26479

To: nazark
Cc: wbauer, hindenburg, konsole-devel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200108/0ac2a150/attachment.html>


More information about the konsole-devel mailing list