[konsole] [Bug 417326] New: The cursor is drawn one pixel off its expected Y-coordinate

[Arthur Kasimov]

https://bugs.kde.org/show_bug.cgi?id=417326

            Bug ID: 417326
           Summary: The cursor is drawn one pixel off its expected
                    Y-coordinate
           Product: konsole
           Version: master
          Platform: Archlinux Packages
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: konsole-devel at kde.org
          Reporter: kodemeister at outlook.com
  Target Milestone: ---

Created attachment 125775
  --> https://bugs.kde.org/attachment.cgi?id=125775&action=edit
Screenshot of gap 1

When Konsole draws the cursor, it always shifts down cursor Y position by one
pixel. Usually it is not noticeable but in some applications, e.g. Vim, it
produces an annoying gap on highlighted background.

For example, when you search a text in Vim, it highlights all occurrences of
that text in a file. When you place the cursor over the highlighted text, a
small but noticeable gap appears. Another example is highlighting of matching
parentheses which reveals the same gap. Please check the attached screenshots.

The adjustment of cursor position is located in TerminalDisplay::drawCursor:

// shift rectangle top down one pixel to leave some space
// between top and bottom
QRectF cursorRect = rect.adjusted(0, 1, 0, 0);

Not sure whether this adjustment is still useful for some purposes or not. 
Shouldn't we simply remove it?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.