[konsole] [Bug 430311] New: Intensive color selection broken as of 270d6ea3

[Antonio Russo]

https://bugs.kde.org/show_bug.cgi?id=430311

            Bug ID: 430311
           Summary: Intensive color selection broken as of 270d6ea3
           Product: konsole
           Version: 20.12.0
          Platform: unspecified
                OS: All
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: font
          Assignee: konsole-devel at kde.org
          Reporter: aerusso at aerusso.net
  Target Milestone: ---

SUMMARY

Commit 270d6ea3247bb41a51535129e4b1c8eef51cf316 breaks the ability to use
intensive colors.  This commit claims to fix the readability issue 405345, but
the bug reporter indicated in 

https://www.mail-archive.com/kde-bugs-dist@kde.org/msg343586.html

that the bug was fixed by an unrelated commit a year prior.

The motivation for removing the intensive color, as far as I can tell, is laid
out in

https://www.mail-archive.com/kde-bugs-dist@kde.org/msg341954.html

However, this email by a non-KDE developer misses that, if you want to not have
an intense color, you can simply choose a color scheme that has the same normal
and intense color settings.  That comment raises as an issue, black-on-white
color schemes readability.

STEPS TO REPRODUCE
1. Request an intensive font color in the color selection dialog, or use a
standard font color scheme with intense colors.
2. Print an intensive font color, i.e., echo -e '\e[1mfoobar

OBSERVED RESULT

The color of the font is not as requested, it is simply the normal color.

EXPECTED RESULT

The color of the font should be as specified in the intense color column.

SOFTWARE/OS VERSIONS
This is present as of 270d6ea3247bb41a51535129e4b1c8eef51cf316 in master, or
82806a2c129f8fa4b21be25b4108eecd8d460625 in 20.12.0, which cherry picks that
commit.

ADDITIONAL INFORMATION

A better solution to the readability issues raised in

https://www.mail-archive.com/kde-bugs-dist@kde.org/msg341954.html

is to use the existing robust configuration options available to adjust the
dark-on-light color schemes to have richer, rather than fainter, intense
colors.  There is no reason to remove simultaneously remove a configuration
option, and change the default behavior that users have expected for over a
decade.

I propose to revert the commit in question, and adjust the defaults in the
dark-on-light color schemes.

P.S. The default colors in the faint categories are probably my fault
(sorry)---I chose them somewhat randomly back when I implemented faint color
support.

-- 
You are receiving this mail because:
You are the assignee for the bug.