[konsole] [Bug 416376] FileFilter only filters files in the current working directory, but not sub-directories

[Vadim A. Misbakh-Soloviov]

https://bugs.kde.org/show_bug.cgi?id=416376

--- Comment #10 from Vadim A. Misbakh-Soloviov (mva) <kde at mva.name> ---
btw, I just found that filter matches (and so konsole underlines) **ALL** the
strings **starting with** known file name (not only between ''s).

Preconditions:
I have "dev" and "1" directories in home dir. Also there is some files named
"2", "4", "5" (notice, no "3").

Situation:
I opened tmux, changed dir to one of my git repos (here konsole still thinks
I'm in home dir, since tmux was opened there). Let it be the Gentoo portage
tree (package build scripts, sorted by dirs). Then I pulled changes, and
looking git log.

Here, all the path like "dev-python", "dev-lua", "dev-libs" and whatsoever -
underlines (and files to open since konsole tries to open it in relation to
home dir).

Also things like "100%", "247483" ("... files"), and so on (starting with
1,2,4,5) - underlines too. And yes, "3249" - is not underlined.


So, I think, it definitelly should not work that way (match all that starts
with substring that equals to known file).
At least, I think, for dirs it definitelly needs to check for "/" after the
name.

As for files, I think it should stop the match on last character of the
filename (so, if suspected string is longer, it will not match).

Although, there is a neighbour bug around, that requests filter to support
line/columns specifications (like in compiler output: `my/source/file.c:21:37`)
to and being able to pass that line/col numbers to the custom command.
I think, that should also be taken in mind when fixing

-- 
You are receiving this mail because:
You are the assignee for the bug.