[konsole] [Bug 425162] Konsole fails to build

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=425162

--- Comment #3 from Martin Sandsmark <martin.sandsmark at kde.org> ---
I meant .a files, it impacts build times a bit. might impact LTO as well,
unless we switch to thin archives (which has another bunch of issues).


Alternatively we could do something like this (cmake magic I recently learned),
I think that works more like expected (i. e. isn't impacted by LDFLAGS and
stuff):

  diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
  index 58b3290f..16fd27af 100644
  --- a/src/CMakeLists.txt
  +++ b/src/CMakeLists.txt
  @@ -205,7 +205,7 @@ ki18n_wrap_ui(konsoleprivate_SRCS
   # add the resource files for the ui files
   qt5_add_resources( konsoleprivate_SRCS ../desktop/konsole.qrc)

  -add_library(konsoleprivate ${konsoleprivate_SRCS})
  +add_library(konsoleprivate ${konsoleprivate_SRCS} 
$<TARGET_OBJECTS:konsolesession>)
   generate_export_header(konsoleprivate BASE_NAME konsoleprivate)

   target_link_libraries(konsoleprivate
  diff --git a/src/session/CMakeLists.txt b/src/session/CMakeLists.txt
  index 1e8f86a2..d4271ab8 100644
  --- a/src/session/CMakeLists.txt
  +++ b/src/session/CMakeLists.txt
  @@ -24,7 +24,7 @@ set(konsole_session_SRCS
   )

   add_library(konsolesession
  -    STATIC
  +    OBJECT
       ${konsole_session_SRCS}
   )


It makes it harder to depend on other modules (so with this no other modules
can depend on konsolesession), but that's really a good thing imho.

-- 
You are receiving this mail because:
You are the assignee for the bug.