Fix to Bug 406828

[Tomaz Canabrava]

Hey,

Thank you very much for it.
More users should be like you :)
I’ll test the patch and submit. If you want you could also fork konsole on
invent.kde.org and submit a pull request there, as it’s easier for us to
review and submit with your rights.

Best regards
Tomaz


On Wed, 23 Oct 2019 at 06:54 Petr Velan <petr.velan at gmail.com> wrote:

> Forgot to add the path diff file, sorry.
>
> On Wed, Oct 23, 2019 at 2:53 PM Petr Velan <petr.velan at gmail.com> wrote:
>
>> Hello Konsole devs,
>>
>> I'm using Konsole daily and I encountered the bug described in
>> https://bugs.kde.org/show_bug.cgi?id=406828
>>
>> This is really annoying for me, so I've decided to have a look at the
>> cause. It seems pretty straightforward to fix, so I'm attaching a git diff
>> of the change here. If there is a better place for me to send the fix,
>> please let me know.
>>
>> Thank you,
>> Petr Velan
>>
>>
>> diff --git a/src/ViewContainer.cpp b/src/ViewContainer.cpp
>> index 81157301..5002c977 100644
>> --- a/src/ViewContainer.cpp
>> +++ b/src/ViewContainer.cpp
>> @@ -543,7 +543,9 @@ void TabbedViewContainer::setTabActivity(int index,
>> bool activity)
>>  void TabbedViewContainer::updateActivity(ViewProperties *item)
>>  {
>>      auto controller = qobject_cast<SessionController*>(item);
>> -    auto index = indexOf(controller->view());
>> +    auto topLevelSplitter =
>> qobject_cast<ViewSplitter*>(controller->view()->parentWidget())->getToplevelSplitter();
>> +
>> +    const int index = indexOf(topLevelSplitter);
>>      if (index != currentIndex()) {
>>          setTabActivity(index, true);
>>      }
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20191023/6c8b322a/attachment.html>