Fix to Bug 406828

Petr Velan petr.velan at gmail.com
Wed Oct 23 13:53:52 BST 2019


Hello Konsole devs,

I'm using Konsole daily and I encountered the bug described in
https://bugs.kde.org/show_bug.cgi?id=406828

This is really annoying for me, so I've decided to have a look at the
cause. It seems pretty straightforward to fix, so I'm attaching a git diff
of the change here. If there is a better place for me to send the fix,
please let me know.

Thank you,
Petr Velan


diff --git a/src/ViewContainer.cpp b/src/ViewContainer.cpp
index 81157301..5002c977 100644
--- a/src/ViewContainer.cpp
+++ b/src/ViewContainer.cpp
@@ -543,7 +543,9 @@ void TabbedViewContainer::setTabActivity(int index,
bool activity)
 void TabbedViewContainer::updateActivity(ViewProperties *item)
 {
     auto controller = qobject_cast<SessionController*>(item);
-    auto index = indexOf(controller->view());
+    auto topLevelSplitter =
qobject_cast<ViewSplitter*>(controller->view()->parentWidget())->getToplevelSplitter();
+
+    const int index = indexOf(topLevelSplitter);
     if (index != currentIndex()) {
         setTabActivity(index, true);
     }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20191023/d12cf71a/attachment.html>


More information about the konsole-devel mailing list