D25151: Fix tabs not indicating activity

Kurt Hindenburg noreply at phabricator.kde.org
Thu Nov 7 15:05:59 GMT 2019


hindenburg accepted this revision.
hindenburg added a comment.
This revision is now accepted and ready to land.


  In D25151#559473 <https://phabricator.kde.org/D25151#559473>, @anthonyfieroni wrote:
  
  > I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.
  
  
  This line is used a number of times and can be fixed afterwards.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D25151

To: velan, #konsole, hindenburg
Cc: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole, fbampaloukas, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20191107/a77b0644/attachment-0001.html>


More information about the konsole-devel mailing list