D21516: Suffixes of Edit Profile - General - Initial Terminal Size don't agree with what they set

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Konsole.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
marten requested review of this revision.

REVISION SUMMARY
  This dialogue page has two spin boxes setting the initial terminal size.  They are no longer individually labelled, but the first one has suffix "rows" and the second has "columns".  However, they actually set the columns and rows respectively.  The default settings are 80 for the first box and 24 for the second, which are obviously the column and row settings.

TEST PLAN
  Built Konsole with this change.  Checked that the spin box suffixes are "columns" and 'rows" respectively and agree with what they set.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D21516

AFFECTED FILES
  src/EditProfileDialog.cpp

To: marten, #konsole
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190531/d8ee5712/attachment.html>