D21301: Add a TerminalHeader when using splits

[Nathaniel Graham]

ngraham added a comment.


  Fantastic. The dark inactive tab is maybe a bit too dark, but that's a fairly minor thing.
  
  One remaining UI niggle I can see is that I'd like a horizontal line separating the headerbars from the menubar for the case where the tab bar is hidden. When the tab bar is shown, it provides its own line, which looks good: F6841233: Screenshot_20190521_094624.png <https://phabricator.kde.org/F6841233>
  
  But when the tab bar is hidden, there's no separation and it looks a bit weird: F6841236: Screenshot_20190521_094723.png <https://phabricator.kde.org/F6841236>
  
  Or maybe this isn't a big deal? What do you think? #VDG <https://phabricator.kde.org/tag/vdg/>?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D21301

To: tcanabrava, #konsole, hindenburg, ngraham, #vdg
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190521/87f93768/attachment.html>