[konsole] [Bug 406752] Menu for "New Tab" button shown in incorrect location for non-first triggering

Arfrever Frehtes Taifersar Arahesis bugzilla_noreply at kde.org
Sat May 4 03:53:40 BST 2019


Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA at GMail.Com> changed:

           What    |Removed                     |Added
                 CC|                            |david at davidhallas.dk

--- Comment #6 from Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA at GMail.Com> ---
This problem was introduced in commit 03a78c2a9f4248653e928c341bb4610c4aeea33b:


commit 03a78c2a9f4248653e928c341bb4610c4aeea33b (HEAD)
Author:     David Hallas <david at davidhallas.dk>
AuthorDate: 2019-03-28 08:55:18 -0400
Commit:     Kurt Hindenburg <kurt.hindenburg at gmail.com>
CommitDate: 2019-03-28 09:14:13 -0400

    Fixes minor memory leaks

    Fixes a few minor memory leaks found with address sanitizer.
    The newTabButton and closeTabButton was not passed a parent and is not
    deleted in the destructor of TabbedViewContainer which will cause them
    to be leaked when closing a tab. Instead pass the TabbedViewContainer as
    the parent.
    The same goes for the profileMenu, it was not passed a parent pointer at
    contruction and the setMenu function doesn't take ownership of it, so
    therefore it was also leaked.

    Test Plan:
    Compile konsole with address sanitizer.
    Open and close konsole.

    Reviewers: #konsole, hindenburg

    Reviewed By: #konsole, hindenburg

    Subscribers: hindenburg, konsole-devel

    Tags: #konsole

    Differential Revision: https://phabricator.kde.org/D19634

You are receiving this mail because:
You are the assignee for the bug.

More information about the konsole-devel mailing list