D19859: Set patch number in QT_MIN_VERSION to 0

[Mariusz Glebocki]

mglb added a comment.


  In D19859#434395 <https://phabricator.kde.org/D19859#434395>, @hindenburg wrote:
  
  > To get it compile w/ 5.9.4, I have to comment out all the QCOMPAREs  - I thought I tested this w/ 5.9.7 but I appear to have upgraded my VMs
  >
  > src/autotests/KeyboardTranslatorTest.cpp:112: error: undefined reference to 'bool QTest::qCompare<Qt::Key, int>(Qt::Key const&, int const&, char const*, char const*, char const*, int)'
  
  
  Turns out it was a code with undefined behavior:
  
  > QCOMPARE is very strict on the data types. Both actual and expected have to be of the same type, otherwise the test won't compile. This prohibits unspecified behavior from being introduced; that is behavior that usually occurs when the compiler implicitly casts the argument.
  >  https://doc.qt.io/qt-5.9/qtest.html#QCOMPARE
  
  
  
  In D19859#434854 <https://phabricator.kde.org/D19859#434854>, @hindenburg wrote:
  
  > I changed it to 5.9.4; it required some #ifs in KeyboardTranslatorTest.cpp;  the only 5.9.x I could find were .4 and .5
  
  
  When I need different Qt version than available in OS repos, I use prebuilt Qt from qt.io - all Qt5 versions available (at least in online installer).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D19859

To: mglb, #konsole
Cc: hindenburg, konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190321/c3f4b422/attachment.html>