D19634: Fixes minor memory leaks

[David Hallas]

hallas created this revision.
hallas added a reviewer: Konsole.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes a few minor memory leaks found with address sanitizer.
  The newTabButton and closeTabButton was not passed a parent and is not
  deleted in the destructor of TabbedViewContainer which will cause them
  to be leaked when closing a tab. Instead pass the TabbedViewContainer as
  the parent.
  The same goes for the profileMenu, it was not passed a parent pointer at
  contruction and the setMenu function doesn't take ownership of it, so
  therefore it was also leaked.

TEST PLAN
  Compile konsole with address sanitizer.
  Open and close konsole.

REPOSITORY
  R319 Konsole

BRANCH
  fix_minor_memory_leaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19634

AFFECTED FILES
  src/ViewContainer.cpp

To: hallas, #konsole
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190309/07ffe956/attachment.html>