[konsole] [Bug 408775] Do not close/destroy tab when closing view

[Bernd Steinhauser]

https://bugs.kde.org/show_bug.cgi?id=408775

--- Comment #7 from Bernd Steinhauser <linux at bernd-steinhauser.de> ---
(In reply to tcanabrava from comment #6)
> > It still closes the session in the split view if you close it, but at
> > least you
> > can't close multiple tabs accidentally.
> 
> 
> In my tests it asks you if you want to close if you have an open app, if
> you have nothing opened then it just closes. If you want me to look for a
> different proposal, I'm all ears. Maybe asking to close if there's more
> than two  views in a split?

Yes, it does ask if a program is running, so that is fine.
I think the situation where you close multiple tabs when closing a view doesn't
occur anymore, since the splitting is now per tab instead of tabs per split.

> > Seems to be bugged if you split both vertically and horizontally though.
> 
> 
> How? I'm using daily and I'm not experiencing bugs. Can you tell me what
> seems wrong? I imagine leme ted recursive splitting so you can have a panel
> on the vertical and other in horizontal, the old behavior was bugged: it
> shifted the horizontal into vertical, the actual one cottectly handles both
> in the same view.

If I do split H and then V, the two smaller panels don't really work. The
property bar with the expand/close buttons is only visible on the lower one,
there are some graphical bugs and on one occasion konsole actually opened a new
half-sized window with the actual session running that should be in the upper
view of the V split.
Looking closer at it, it doesn't seem to be a problem with combo splitting, but
rather that vertical splitting (which I normally don't use) is bugged.
I see the same behavior if I do only split vertically.
Funnily enough by doing this and closing the original session, I managed to
drive konsole to a stage where I do now have konsole without a session running
in this tab. I'll attach a screen of that.

> You are the 3rd person asking for this so I'm really thinking on re adding
> it, but as I said I need help in the form of code.

Sorry, I'm not really familiar with c++.
I did some messing around with Audex code, but that was all very straight
forward stuff and nothing where you actually had to be creative, so I doubt I
could be of help here. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.