D21849: Fixes crash when copying hotspot

David Hallas noreply at phabricator.kde.org
Sun Jun 16 16:30:17 BST 2019


hallas created this revision.
hallas added reviewers: Konsole, hindenburg.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes crash when copying hotspot. It is caused by the code would remove
  any actions from the hotspot after the context menu had executed, but
  these actions have now been freed because the hotspot is freed (this was
  done in 7265be97a2e9d84c4e036d426ffb0085710d9361 <https://phabricator.kde.org/R319:7265be97a2e9d84c4e036d426ffb0085710d9361> to fix a memory leak).

TEST PLAN
  echo https://kde.org/
  edit->find
  type kde in the search box
  select kde.org
  right click and click copy
  
  BUG: 408603

REPOSITORY
  R319 Konsole

BRANCH
  fix_crash_when_copying_hotspot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21849

AFFECTED FILES
  src/SessionController.cpp

To: hallas, #konsole, hindenburg
Cc: konsole-devel, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190616/a29fdf9e/attachment.html>


More information about the konsole-devel mailing list