[konsole] [Bug 408775] Do not close/destroy tab when closing view

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=408775

--- Comment #1 from tcanabrava at kde.org ---
I understand the issue here and I'll provide a patch for that.


>
> In general, I'm not quite sure about the splitted tab bars, since imo it
> creates a lot of unnecessary dragging of windows.
> I can see though why some people would want that.
>

There's no need to drag windows, you can navigate with the keyboard.

>
> My suggestion would be:
>
> On splitting:
> If there is only one tab active, open a new tab in the new view to avoid
> having
> to open the new tab manually.
>

splitting doesn't opens a new tab, why do you belive so?

If there are two or more tabs, leave the active tab in the current view and
> split the most recently used inactive tab into the new view.
>

Can you ellaborate on that? from what you explained I don't see how this
could be userfriendly.
I Implemented the split views as it's done in Terminator and Tilix (and
those are currently most used than konsole for userfriendlyness)


> On closing a view:
> Do not destroy any tabs. Really. Don't. _Especially_ not with running
> programs
> inside and without warning.
>

I'll add the check for running programms.

Tabs should *always* be closed by the user, _actively_.
> Instead merge the two tab bars.
>

Tabs are only closed by the users, the only way to close a tab withotu
explicit user is to close the *last* terminal inside of a tab. I can't have
terminals with nothing inside.

For the rest (the mirror mode that you seem keen on using it again) - I'm
not against it but the implementation was broken so I replaced by the
current split code. I'm just one developer and I would happily add the
split mode again, if well developed. Patches welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.