D17757: Fix crash in extendSelection

Tomaz Canabrava tcanabrava at kde.org
Mon Jan 21 20:23:58 GMT 2019


A crash is better than a wrong selection ?

Em seg, 21 de jan de 2019 às 21:05, Nathaniel Graham <
noreply at phabricator.kde.org> escreveu:

> ngraham reopened this revision.
> ngraham added a comment.
> This revision is now accepted and ready to land. View Revision
> <https://phabricator.kde.org/D17757>
>
> This patch caused a critical regression on the stable branch:
> https://bugs.kde.org/show_bug.cgi?id=403117. This issue is affecting
> users on rolling release distros with KDE Applications 18.12.1.
>
> I have reverted this patch on both the stable branch and master. Please
> feel free to give it another try, but this time please add an autotest for
> the failure condition in 403117 so we can make sure it doesn't regress
> again. Thanks!
>
> *REPOSITORY*
> R319 Konsole
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D17757
>
> *To: *pavelkh, Konsole, hindenburg
> *Cc: *ngraham, konsole-devel, thsurrel, maximilianocuria, hindenburg
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190121/4aea63f0/attachment.html>


More information about the konsole-devel mailing list