D19269: Minor cleanup/optimizations in font changing code

Kurt Hindenburg noreply at phabricator.kde.org
Thu Feb 28 02:57:21 GMT 2019


hindenburg added inline comments.

INLINE COMMENTS

> TerminalDisplay.cpp:298
> +    if (fontInfo.family() != newFont.family()
> +            || fontInfo.pointSizeF() != newFont.pointSizeF()
> +            || fontInfo.styleHint()  != newFont.styleHint()

I see compiler warning that comparing floats with != is unsafe

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D19269

To: mglb, #konsole, hindenburg
Cc: hindenburg, ngraham, konsole-devel, gennad, maciejn, thsurrel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190228/2403b1e7/attachment.html>


More information about the konsole-devel mailing list