D19400: Resize Edit Profile dialog only when possible

[Mariusz Glebocki]

mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Initial window width is set to be wider than (default) minimum possible
  size. This adds some whitespace and increases width of text inputs
  on "tabs" page.
  
  This was made unconditionally, which could increase the width past
  screen's right edge on small screens.
  
  It is changed to be at most 2/3 of the screen's width now. Note that
  minimum window size is still in effect; the limit affects only
  additional width.

TEST PLAN
  (Instructions for X11)
  
  - Run `Xephyr -dpi 96 -size 800x600 :1`
  - Run `DISPLAY=:1 kwin_x11`
  - Run `DISPLAY=:1 ./konsole`
  - Open edit profile dialog, resize it to minimum allowable size.
  - Measure the window size.
  - Close Xephyr.
  - Run `Xephyr -dpi 96 -size WxH :1`, where `W` is the measured window width + 20, and `H` is anything larger than measured height.
  - Run `DISPLAY=:1 kwin_x11`
  - Run `DISPLAY=:1 ./konsole`
  - Open edit profile dialog
  
  **Expected result:**
  Edit Profile dialog's width should be a bit smaller than Xephyr's
  screen

REPOSITORY
  R319 Konsole

BRANCH
  arc/Resize-Profile-Settings-dialog-only-when-possible (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19400

AFFECTED FILES
  src/EditProfileDialog.cpp

To: mglb, #konsole
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190227/fc99e451/attachment.html>