D16138: Create the default profile if it doesn't exist

Pedro Arthur P. R. Duarte noreply at phabricator.kde.org
Tue Feb 26 14:30:56 GMT 2019


pedroarthurp added a comment.


  In D16138#419673 <https://phabricator.kde.org/D16138#419673>, @hindenburg wrote:
  
  > Testing this and a few concerns right off the start
  >
  > 1. manage profiles doesn't show any of my profiles (should be 5)
  
  
  A `setHidden(false)` was missing.
  
  > 2. The 'Favorite Profiles' doesn't really express the idea that the current session will be changed to the selected profile.
  
  Agreed. However, switch profile doesn't state that it will show only a subset of my profile.
  
  > 3. have you tested 'konsole --fallback-profile '
  
  Yes. It was working as expected.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16138

To: pedroarthurp, tcanabrava, ngraham, #konsole, hindenburg
Cc: sandsmark, cfeck, ngraham, konsole-devel, gennad, maciejn, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190226/514ff9b8/attachment.html>


More information about the konsole-devel mailing list