D17643: Multiple Splits per Tab

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> konsoleui.rc:3
>  
>  <kpartgui name="konsole" version="10">
>      <MenuBar>

Increase version

> MainWindow.cpp:321-322
>      _newTabMenuAction->setAutoRepeat(false);
>      connect(_newTabMenuAction, &KActionMenu::triggered,
> -            this, [this] { newTab(_viewManager->activeContainer());});
> +            this, [this] { newTab(); });
>      collection->addAction(QStringLiteral("new-tab"), _newTabMenuAction);

Can you connect like:

  connect(_newTabMenuAction, &KActionMenu::triggered, this, &MainWindow::newTab);

> MainWindow.cpp:395-396
>  
>      connect(list, &Konsole::ProfileList::profileSelected, this,
> -            [this](const Profile::Ptr &profile) { newFromProfile(_viewManager->activeContainer(), profile);});
> +            [this](const Profile::Ptr &profile) { newFromProfile(profile);});
>  

Same as above

  connect(list, &Konsole::ProfileList::profileSelected, this, &MainWindow::newFromProfile);

> ViewContainer.cpp:90-92
>      connect(tabBarWidget, &DetachableTabBar::detachTab, this, [this](int idx) {
> -        emit detachTab(this, terminalAt(idx));
> +        emit detachTab(idx);
>      });

connect(tabBarWidget, &DetachableTabBar::detachTab, this, &TabbedViewContainer::detachTab);

> ViewContainer.cpp:96-97
>          this, &TabbedViewContainer::closeTerminalTab);
>      connect(tabBarWidget, &DetachableTabBar::newTabRequest,
> -        this, [this]{ emit newViewRequest(this); });
> +        this, [this]{ emit newViewRequest(); });
>      connect(this, &TabbedViewContainer::currentChanged, this, &TabbedViewContainer::currentTabChanged);

Connecting signal to signal should work, same as above.

> ViewManager.cpp:604-605
>  
> -    _viewSplitter->setFocusProxy(controller->view());
> +    //TODO: Verify This.
> +    // _viewSplitter->setFocusProxy(controller->view());
> +

This should stay, i think.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17643

To: tcanabrava, #konsole
Cc: anthonyfieroni, gennad, ngraham, thsurrel, maciejn, mglb, hindenburg, konsole-devel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190226/96d22a91/attachment.html>