D19266: For MacOS portion, use nullptr instead of NULL

[Mariusz Glebocki]

mglb created this revision.
mglb added reviewers: Konsole, VDG.
mglb added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Fix "Draw intense colors in bold font" feature
  
  Make the feature work and improve it slightly - the weight used as bold
  is dependent on selected font's weight. "Regular" will use "Bold", but
  e.g. "Thin" will use "Light".
  
  `styleName` is almost always redundant - all font properties like
  weight, stretch, etc, are stored separately.
  
  Source Code Pro 12pt with font weight set to: Extra Light, Light,
  Regular, Medium, Semibold, Bold:
  F6631951: source-code-pro-12pt.png <https://phabricator.kde.org/F6631951>

TEST PLAN
  In every case: turn on "Draw intense colors in bold font" in Edit
  Profile → Appearance.
  
  The feature:
  
  - Use some font which has "Bold" style available and set it to "Regular" style.
  - Run: `printf '\033[1mBold|\033[0m|Normal\n'`
  - "Bold|" text should use bold font.
  
  Different weights:
  
  - Use some font which has multiple weights available (e.g. Thin, Bold, Heavy, ...), e.g. Source Code Pro.
  - Select lightest style.
  - Run: `printf '\033[1mBold|\033[0m|Normal\n'`
  - Select "regular" font style.
  - Bold text for "regular" style should be bolder than the text for lightest style should be.

REPOSITORY
  R319 Konsole

BRANCH
  arc/Fix-bold-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19266

AFFECTED FILES
  src/ProcessInfo.cpp
  src/TerminalDisplay.cpp

To: mglb, #konsole, #vdg
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190223/ea341f34/attachment-0001.html>