D15742: Close tab on middle click event

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> DetachableTabBar.h:32
>      enum class DragType : unsigned char {NONE, OUTSIDE, WINDOW};
> -
>      explicit DetachableTabBar(QWidget *parent = nullptr);

Unnecessary change

> TabBarSettings.ui:102
> +        <property name="text">
> +         <string>Close tab on middle mouse button</string>
> +        </property>

Should be "Close tab on middle-click"

> konsole.kcfg:92
> +    <entry name="CloseTabOnMiddleMouseButton" type="Bool">
> +      <label>Close tab on middle mouse button event</label>
> +      <default>false</default>

Should be "Allow middle-clicking on open tabs to close them"

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D15742

To: shubham, ngraham, hindenburg, tcanabrava
Cc: thsurrel, ngraham, hindenburg, shubham, broulik, konsole-devel, gennad, maciejn, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190216/1d76d66f/attachment.html>