D14200: Simplify newSession code
Kurt Hindenburg
noreply at phabricator.kde.org
Fri Feb 15 15:46:12 GMT 2019
hindenburg added inline comments.
INLINE COMMENTS
> ViewManager.cpp:1013
> {
> - Profile::Ptr profile = ProfileManager::instance()->defaultProfile();
> - Session *session = SessionManager::instance()->createSession(profile);
> -
> - session->addEnvironmentEntry(QStringLiteral("KONSOLE_DBUS_WINDOW=/Windows/%1").arg(managerId()));
> -
> - createView(session);
> - session->run();
> -
> - return session->sessionId();
> + return newSession(ProfileManager::instance()->defaultProfile()->name());
> }
simpler toalso add the , QString() as below?
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D14200
To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190215/b21b5802/attachment.html>
More information about the konsole-devel
mailing list