D18520: Remove dead code in TerminalDisplay
Tomaz Canabrava
noreply at phabricator.kde.org
Sat Feb 9 15:07:46 GMT 2019
tcanabrava added a comment.
I tough about that but it’s not that easy unless we also refactor the
Profile class, because everything in the profile class is stored inside a
map. It would be quite expensive to always access it.
Em sex, 8 de fev de 2019 às 20:56, Martin Tobias Holmedahl Sandsmark <
noreply at phabricator.kde.org> escreveu:
> sandsmark added a comment. View Revision
> https://phabricator.kde.org/D18520
>
> I've been wanting to refactor it to remove all the individual getters and
> setters in TerminalDisplay, and just let TerminalDisplay hold the
> Profile::Ptr, then terminaldisplay can just directly use the values from
> Profile instead of duplicating all the variables and getters/setters.
>
> *REPOSITORY*
> R319 <https://phabricator.kde.org/source/konsole/> Konsole
>
> *REVISION DETAIL*
> https://phabricator.kde.org/D18520
>
> *To: *tcanabrava, Konsole, hindenburg, ngraham
> *Cc: *sandsmark, konsole-devel, maciejn, thsurrel, ngraham,
> maximilianocuria, hindenburg
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D18520
To: tcanabrava, #konsole, hindenburg, ngraham
Cc: sandsmark, konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190209/dd895600/attachment-0001.html>
More information about the konsole-devel
mailing list