D18870: Clean up/refactor selection code in TerminalDisplay

[Martin Tobias Holmedahl Sandsmark]

sandsmark created this revision.
sandsmark added reviewers: Konsole, hindenburg, ngraham, pavelkh, glenncoombs, yuyichao.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
sandsmark requested review of this revision.

REVISION SUMMARY
  Clarified the variable and member names, straightened out the code flow, fixes the (crashing) issue with the selections properly.
  
  Also have a separate patch on top of this to move most of the code out of TerminalDisplay (my goal is to get TerminalDisplay.cpp below 3000 lines :-).

TEST PLAN
  Same as the ones from the earlier commits related to this, but no autotests yet (want to wait until the code is in the right place first).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18870

AFFECTED FILES
  src/Screen.cpp
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: sandsmark, #konsole, hindenburg, ngraham, pavelkh, glenncoombs, yuyichao
Cc: konsole-devel, #konsole, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190209/f6f80ebb/attachment.html>