D18735: Improve built-in line/box characters drawing

Mariusz Glebocki noreply at phabricator.kde.org
Sat Feb 9 04:02:29 GMT 2019


mglb marked 3 inline comments as done.
mglb added inline comments.

INLINE COMMENTS

> fvogt wrote in LineBlockCharacters.cpp:193
> For `fontWidth` less than 8 this returns 1 for both bold and normal lines. Intentional?
> 
> IMO increasing the `LightWidthToFontSizeRatio` to `1/5`  is acceptable.

It now returns 1 for normal and bold lines when the fontWidth is less than 7. It is just not possible to fit bold characters in such narrow space.

1/5 turned out to be too low. 1/6.5 works best. Minimum bold line width
is now set to normal line width + 1, so it is always bolder for character widths >= 7.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18735

To: mglb, #konsole, #vdg, fvogt
Cc: sandsmark, fvogt, konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190209/fc25341a/attachment-0001.html>


More information about the konsole-devel mailing list