D18862: Fix crash when extending selection
Martin Tobias Holmedahl Sandsmark
noreply at phabricator.kde.org
Fri Feb 8 19:47:10 GMT 2019
sandsmark created this revision.
sandsmark added reviewers: hindenburg, pavelkh, ngraham.
Herald added a project: Konsole.
Herald edited subscribers, added: konsole-devel; removed: Konsole.
sandsmark requested review of this revision.
REVISION SUMMARY
When doing word selection use the previous selection anchor if the new one is out of bounds (user scrolled out of view or similar).
A more proper (but still not really proper) fix than b85bbaa8c8807ab3619cddc35b634c2bb43e09fb <https://phabricator.kde.org/R319:b85bbaa8c8807ab3619cddc35b634c2bb43e09fb> reverted by 213afc0e0ceebc88c90552cd91fa8680e54603ed <https://phabricator.kde.org/R319:213afc0e0ceebc88c90552cd91fa8680e54603ed>
I have a branch refactoring the word selection stuff a bit, but it's a bit more invasive. This is the minimal change I could get to fix it.
TEST PLAN
see b85bbaa8c8807ab3619cddc35b634c2bb43e09fb <https://phabricator.kde.org/R319:b85bbaa8c8807ab3619cddc35b634c2bb43e09fb> 213afc0e0ceebc88c90552cd91fa8680e54603ed <https://phabricator.kde.org/R319:213afc0e0ceebc88c90552cd91fa8680e54603ed> 914067d14a6a27b59bba1c53cc18cb67eb9811fc <https://phabricator.kde.org/R319:914067d14a6a27b59bba1c53cc18cb67eb9811fc>
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D18862
AFFECTED FILES
src/TerminalDisplay.cpp
To: sandsmark, hindenburg, pavelkh, ngraham
Cc: konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190208/ec6b0252/attachment.html>
More information about the konsole-devel
mailing list