D18606: [RFC]Close tab on middle mouse button event

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  > There is already a confirmation dialog when you close a tab with a running process, so unless we cleverly account for that, this would result in two dialogs.
  
  Makes sense, that was actually why I thought about it, but two dialogs is a bit too much indeed.
  
  Every config options add a ton of extra code, though, but it's probably better to just refactor that in general.
  
  > I don't think we should present a dialog box because previously I have heard that dialog boxes are annoying to most users. @ngraham will know it.
  
  Yeah, dialogs are bad if they happen too often, but config options aren't always good either (discoverability etc.).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18606

To: shubham, hindenburg, #konsole, ngraham
Cc: sandsmark, pino, #konsole, konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190208/0e9af4fc/attachment.html>