D18784: Extend character clipping by grouping it with spaces
Mariusz Glebocki
noreply at phabricator.kde.org
Wed Feb 6 10:52:28 GMT 2019
mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.
REVISION SUMMARY
Group spaces following any non-wide character with the character. This
allows for rendering ambiguous characters with wide glyphs without
clipping them. Characters are still clipped when followed by another
visible character.
F6591346: Screenshot_2019-02-06-11-26-55.png <https://phabricator.kde.org/F6591346>
BUG 401298
TEST PLAN
- Display: `⛰ ⛩ `
and/or:
- Install Font Awesome or other font with square icons in Private Use Area
- Pick some icons using KCharSelect or similar tool (or copy this: ` `)
- Put space after each icon and display them in Konsole
**Actual result:**
Only left half of icons is rendered
**Expected result:**
Full icon should be rendered (it can be clipped on top or bottom though)
REPOSITORY
R319 Konsole
BRANCH
arc/Extend-character-clipping-by-grouping-it-with-spaces (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18784
AFFECTED FILES
src/TerminalDisplay.cpp
To: mglb, #konsole
Cc: konsole-devel, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190206/29c4bcd0/attachment-0001.html>
More information about the konsole-devel
mailing list