[konsole/martin/cleanupfindwordendstart] src: terminaldisplay: correctly set whether we want edge selection

[kurt.hindenburg at gmail.com]

Hello,

Can you put this on phabicator as it makes it easier to discuss?


I can get it to crash by clicking text and then scrolling up and 
clicking to extendselection


ASSERT: "y >= 0 && y < _lines" in file 
/home/kurthindenburg/Devel/KDE/src/kde/applications/konsole/src/TerminalDisplay.cpp, 
line 88


Kurt


On 1/21/19 3:37 PM, Martin T. H. Sandsmark wrote:
> Git commit 43c4516c02939578ecd283a42d88d670dd38f34d by Martin T. H. Sandsmark.
> Committed on 21/01/2019 at 20:37.
> Pushed by sandsmark into branch 'martin/cleanupfindwordendstart'.
>
> terminaldisplay: correctly set whether we want edge selection
>
> M  +1    -1    src/TerminalDisplay.cpp
>
> https://commits.kde.org/konsole/43c4516c02939578ecd283a42d88d670dd38f34d
>
> diff --git a/src/TerminalDisplay.cpp b/src/TerminalDisplay.cpp
> index 4c5b6475..a38bbf6e 100644
> --- a/src/TerminalDisplay.cpp
> +++ b/src/TerminalDisplay.cpp
> @@ -2681,7 +2681,7 @@ void TerminalDisplay::extendSelection(const QPoint& position)
>   
>       int charColumn = 0;
>       int charLine = 0;
> -    getCharacterPosition(pos, charLine, charColumn, true);
> +    getCharacterPosition(pos, charLine, charColumn, !_wordSelectionMode && !_lineSelectionMode);
>   
>       QPoint here = QPoint(charColumn, charLine);
>       QPoint ohere;
>