[konsole] [Bug 410607] In 'Confirm Close' dialog, pressing 'Close current Tab' causes crash

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=410607

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/kde/
                   |                            |konsole/commit/62a5f1d7947d
                   |                            |4f101d036ba98c9b6cccc3b69a9
                   |                            |7
             Status|REPORTED                    |RESOLVED
   Version Fixed In|                            |19.08.1
         Resolution|---                         |FIXED

--- Comment #3 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 62a5f1d7947d4f101d036ba98c9b6cccc3b69a97 by Kurt Hindenburg.
Committed on 18/08/2019 at 20:51.
Pushed by hindenburg into branch 'master'.

Fix crash on "Close Current Tab" handling

Summary:
_pluggedController disconnection happens  when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash.   Also a case when
closeInNormalWay is false was not considered.
FIXED-IN: 19.08.1

Test Plan:
1. Open Konsole
2. Open one more tab
3. Try to close Konsole
4. Pick option "Close Current Tab" (assuming you have not check
    'Do not ask again')

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D23246

M  +5    -2    src/MainWindow.cpp

https://invent.kde.org/kde/konsole/commit/62a5f1d7947d4f101d036ba98c9b6cccc3b69a97

-- 
You are receiving this mail because:
You are the assignee for the bug.