D20263: Keep perceived contrast in random background color

[Kurt Hindenburg]

hindenburg added inline comments.

INLINE COMMENTS

> ColorScheme.cpp:41
>  namespace {
> -const int FGCOLOR_INDEX = 0;
> -const int BGCOLOR_INDEX = 1;
> +static const int FGCOLOR_INDEX = 0;
> +static const int BGCOLOR_INDEX = 1;

nitpick - you don't need to fix these now -  "static definition in anonymous namespace; static is redundant here"

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20263

To: mglb, #konsole, #vdg
Cc: hindenburg, #vdg, #konsole, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, ngraham, skadinna, maximilianocuria, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190817/d02eaede/attachment-0001.html>