Konsole OSC + ST (231405)

[Mariusz Glebocki]

Hi,

WIP, a bit dirty and without automatic test, but seems to work:
https://invent.kde.org/kde/konsole/merge_requests/22

On Thu, Aug 15, 2019 at 4:47 PM <kurt.hindenburg at gmail.com> wrote:
>
> Hi, I was actually looking at this recently but got distracted. If no
> one else picks it up, I'll try again.
>
>
> Kurt
>
> On 8/15/19 6:01 AM, Egmont Koblinger wrote:
> > Hi guys,
> >
> > I hope you don't mind me reaching out directly to you.
> >
> > I'd like to kindly ask you to address
> > https://bugs.kde.org/show_bug.cgi?id=231405 in the near future.
> > There's a pending patch attached to the bug.
> >
> > According to the standard, namely ECMA-48 § 8.3.89 and 8.3.143, an OSC
> > sequence has to be terminated by ST, whose C0 representation is ESC
> > Backslash. Konsole mishandles this one. (It handles correctly the
> > nonstandard but common practice of BEL as terminator instead, which as
> > per the XTerm FAQ, originates from XTerm.)
> >
> > As Bruno (cc) pointed out, this parser bug blocks him from emitting
> > OSC sequences (OSC 8 hyperlink in particular, see konsole bug 379294)
> > in a standard confirming way, knowing that terminals would at least
> > silently ignore the sequence, without messing up the screen. Konsole
> > (and derivatives, e.g. yakuake) are the only popular modern terminal
> > emulators we're aware of that are problematic here, the other
> > problematic emulators belong to the long tail (unmaintained ones, or
> > ones with very small use base).
> >
> > This bugfix for Konsole would be an important step in allowing the
> > whole ecosystem of terminals and terminal-based applications to move
> > forward.
> >
> > thanks a lot,
> > egmont