D20836: Fix New tab behavior

Tomaz Canabrava noreply at phabricator.kde.org
Fri Apr 26 10:07:56 BST 2019

tcanabrava added a comment.

  O don’t really get it. Why this code needs to go to MainWindow and not to
  TabbedContainer ?
  Seems to me that the class that should have knowledge on how to create the
  tabs is not mainwindow.
  Em sex, 26 de abr de 2019 às 09:55, Thomas Surrel <
  noreply at phabricator.kde.org> escreveu:
  > thsurrel created this revision.
  >  thsurrel added reviewers: Konsole, hindenburg, tcanabrava.
  >  Herald added a project: Konsole.
  >  Herald added a subscriber: konsole-devel.
  >  thsurrel requested review of this revision. View Revision
  >  https://phabricator.kde.org/D20836
  > Fix the regression about the placement of a new tab:
  >  it is now added either at the end, or next to the
  >  current tab depending on the setting.
  > BUG: 406409
  > In Konsole settings, select 'Put new tab after the
  >  current tab' for the New tab behavior setting.
  >  Open some new tabs and check they are opened at the
  >  proper position.
  >  R319 <https://phabricator.kde.org/source/konsole/> Konsole
  > *BRANCH*
  > arc_newtab
  >  https://phabricator.kde.org/D20836
  >  src/MainWindow.cpp
  >  src/MainWindow.h
  >  src/ViewContainer.cpp
  >  src/ViewManager.cpp
  >  src/ViewManager.h
  > *To: *thsurrel, Konsole, hindenburg, tcanabrava
  >  *Cc: *konsole-devel, gennad, thsurrel, ngraham, maximilianocuria,
  > hindenburg

  R319 Konsole


To: thsurrel, #konsole, hindenburg, tcanabrava
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190426/4a39e9a6/attachment.html>

More information about the konsole-devel mailing list