D20466: Rework scrollback settings

[Tomaz Canabrava]

tcanabrava added a comment.


  In D20466#448806 <https://phabricator.kde.org/D20466#448806>, @mglb wrote:
  
  > After thinking about scrollback a bit more I think history file path AND scrollback size should go to global settings. Does anyone use different profiles with different history sizes, or change size just for current session?
  >
  > In D20466#448705 <https://phabricator.kde.org/D20466#448705>, @ngraham wrote:
  >
  > > In D20466#448704 <https://phabricator.kde.org/D20466#448704>, @hindenburg wrote:
  > >
  > > > Another way to display this would be to only show the "info box" when unlimited is selected.
  > >
  > >
  > > +1
  >
  >
  > Did you mean -1? :P Hiding part of an UI depending on selected option is bad UX. Moving another elements around because something appears is probably even worse.
  >  It is also against KDE HIG: https://hig.kde.org/patterns/content/settings.html#implementation (last point)
  >
  > About changes:
  >
  > - Maybe putting custom path field below radio button (and indenting it) would be better? Path which appear here will probably be longer than current field width (at least I think so), and it will not be needed to align it with fixed size field
  > - All radio buttons had equal vertical spacing, and the left label was aligned to the first radio button F6768904: scroll-new-old-alignment.png <https://phabricator.kde.org/F6768904>
  > - Button group instead of frame
  > - Maybe kmessagebox instead of label?
  
  
  Can you try to mock up a dialog where I don't hide the information?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20466

To: tcanabrava, #konsole, hindenburg
Cc: mglb, gennad, ngraham, konsole-devel, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190412/58c3a85e/attachment.html>