D20466: Rework scrollback settings

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Settings scrollbar is split in two different panels,
  half of it in "Profile", half of it in "Settings".
  the majority of the settings are in profile, while in
  settings we can only configure where the profile will
  save the temporary file.
  
  While one is local and another is global, I belive that
  this is a bad UX: one should not need to jump thru different
  dialogs to configure related preferences.
  
  Now everything is in Profile configuration. that lead to
  a code reduction of more than half, and also added maintenability.
  
  Next: per-profile settings for the temporary file.

REPOSITORY
  R319 Konsole

BRANCH
  clean_history_save_path

REVISION DETAIL
  https://phabricator.kde.org/D20466

AFFECTED FILES
  src/CMakeLists.txt
  src/EditProfileDialog.cpp
  src/HistorySizeDialog.cpp
  src/HistorySizeWidget.cpp
  src/HistorySizeWidget.h
  src/HistorySizeWidget.ui
  src/MainWindow.cpp
  src/settings/FileLocationSettings.cpp
  src/settings/FileLocationSettings.h
  src/settings/FileLocationSettings.ui

To: tcanabrava
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190411/b11b472d/attachment.html>