[konsole] [Bug 395666] yakuake crashes on multiple touches on the touchscreen

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=395666

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/bfb91aac49f21b2bdf9ee2
                   |                            |b64feaf28d87569bc4
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit bfb91aac49f21b2bdf9ee2b64feaf28d87569bc4 by Kurt Hindenburg.
Committed on 30/09/2018 at 17:48.
Pushed by hindenburg into branch 'master'.

Check clipboard->mimeData() is valid

Summary:

Bug reported crashes on yakuake in a wayland session. Further
investigation revealed that other KDE product Kolourpaint experienced
nullptr on wayland while getting MimeData which was consistent with
the stacktrace provided by the author of the bug.

This diff validates the presence of MimeData before proceeding with
the drag action.

Test Plan:
1. Use wayland session
2. Open Yakuake in fullscreen
3. With a touch enabled laptop, scroll with many fingers (possibly 8)
4. Yakuake should not crash

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: anthonyfieroni, ngraham, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D15794

M  +7    -3    src/TerminalDisplay.cpp

https://commits.kde.org/konsole/bfb91aac49f21b2bdf9ee2b64feaf28d87569bc4

-- 
You are receiving this mail because:
You are the assignee for the bug.